search

alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.18k stars 325 forks source link

Some components active states are broken in compatibility mode #1562

Closed NickColley closed 5 years ago

NickColley commented 5 years ago
Screen Shot 2019-09-09 at 17 36 36

We have run into this issue before here: https://github.com/alphagov/govuk-frontend/pull/1310

This seems to be a problem for other components too, you can see the impact live on GOV.UK: https://www.gov.uk/register-to-vote

You can reproduce this by going to: http://localhost:3000/components/button/start-link/preview?legacy=1

And changing the href to something unique in the example yaml file.

This may be an issue with other components too.

NickColley commented 5 years ago

Not sure if there's a more holistic approach we can have here.

Should all hrefs get automatically be cache busted?

If we did that how do we test visited states?