search

alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.13k stars 319 forks source link

Always test components inside a proper page with assistive technologies #1736

Open NickColley opened 4 years ago

NickColley commented 4 years ago

We should document a decision to test components within a real page instead of isolation as some screen readers we've found behave oddly when the component is the first thing in the page, which could lead to misleading testing results.

m-green commented 4 years ago

Discussed in triage: this is mainly about internal documentation.

36degrees commented 4 years ago

It'd be good to understand exactly what it is that the extra context provides that makes it behave differently.

NickColley commented 4 years ago

@36degrees not entirely sure but there's something about entering into the document and tabbing to a link as the first interaction which means announcements are not as expected, perhaps because it's announcing the document itself and it interrupts things.

36degrees commented 4 years ago

Another thing we discussed in triage – we may want to make changes to the review app to make this the 'default' way to test examples, rather than relying on documentation.