alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.13k stars 319 forks source link

Voiceover/Safari - on first focus of radio button, legend is read out twice #2153

Open joelanman opened 3 years ago

joelanman commented 3 years ago

What

Report bug

Why

On Voiceover in Safari, when I focus to the radio for the first time, the legend is read out twice

https://design-system.service.gov.uk/components/radios/default/index.html

Who needs to know about this

Hanna

Done when

klh commented 2 years ago

just fyi, this is a safari bug, and only workaround is to remove the element and exclusively use aria-label instead...

see: https://codepen.io/lewisjwright/full/bGbpoGw

please log a bug report with apple/webkit

36degrees commented 2 years ago

I think this is a Safari bug which is already covered by https://bugs.webkit.org/show_bug.cgi?id=230824 (which includes the same CodePen test case linked to by @klh above).

klh commented 2 years ago

If you would please +1 report this to apple as well, super hard to get them to fix these issues

Den 20. jun. 2022 kl. 17.58 skrev Oliver Byford @.***>:

 I think this is a Safari bug which is already covered by https://bugs.webkit.org/show_bug.cgi?id=230824 (which includes the same CodePen test case linked to by @klh above).

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

36degrees commented 2 years ago

@klh I've added a comment to the WebKit bug – apologies that I've only just made the connection that you are the original reporter!

klh commented 2 years ago

Ping Apple with it aswell they are notoriously difficult to get to do any of these fixes @apple

On 21 Jun 2022, at 10.46, Oliver Byford @.***> wrote:

@klh https://github.com/klh I've added a comment to the WebKit bug – apologies that I've only just made the connection that you are the original reporter!

— Reply to this email directly, view it on GitHub https://github.com/alphagov/govuk-frontend/issues/2153#issuecomment-1161450788, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAERWTKWXASPACIQXZP7KIDVQF6PTANCNFSM4YA6AXYQ. You are receiving this because you were mentioned.