alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.18k stars 323 forks source link

Secondary colour overriden on child elements if using global styles #2298

Open chrisadesign opened 3 years ago

chrisadesign commented 3 years ago

What

The secondary colour used on hint text is not applied to elements within the div is you are using $govuk-global-styles. The styles for the hint colour need to override things like paragraphs and lists.

image

The screenshot above shows the paragraph tag overriding the secondary colour.

vanitabarrett commented 3 years ago

Hi @chrisadesign 👋 Thanks for raising this issue. I'm going to raise this with the other developers in the team to get their thoughts as I think there's probably a bit of a discussion to be had here about what the recommended use of govuk-global-styles is and whether there's work we need to do to handle those overriding styles in our component styles. I'll add any updates on here once we've discussed it 🙂

vanitabarrett commented 3 years ago

@chrisadesign just wondering - are you using govuk-global-styles here within a prototype or in production?

chrisadesign commented 3 years ago

I'm using it in a prototype, it's enabled by default in the kit.