search

alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.19k stars 327 forks source link

Provide pre-release branches with a `5.x` version number #3661

Closed romaricpascal closed 1 year ago

romaricpascal commented 1 year ago

What

Ensure our pre-release branches start having a 5.x version number as soon as possible.

Why

This will help the Prototype Kit start implementing any adjustment to our breaking changes (for ex. the move of the built files to dist).

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

romaricpascal commented 1 year ago

A couple of options for that, as a starting point:

  1. update the pre-release.sh script and/or the branch pre-release process to include a version bump, quite easy to forget to do, though, and repetitive for if we create multiple pre-release branches for the same upcoming version.
  2. update the version in packages/govuk-frontend/package.json on main, which we should be able to do now the package is no longer versionned (so the number does not need to remain to the last published package for diffing). We would likely want to update our release process to move the version bump from "before-publishing-a-release" to "after-publishing-a-release". Because we're in charge of which work goes in each release (and can always update that number or use a support branch), I think that would work OK.
romaricpascal commented 1 year ago

Not a thing anymore as we pre-release from main.