alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.16k stars 319 forks source link

Test components and patterns for complex WCAG 2.2 criteria (target, focus appearance, focus not obscured) #4347

Open dav-idc opened 11 months ago

dav-idc commented 11 months ago

What

In our initial WCAG 2.2 style component and pattern assessment spreadsheet, I listed several entries as needing more testing.

I then promptly forgot about it and we never tested those.

So this is the epic to get those tested and then take action on any pieces that need design, development or guidance updates.

The initial assessment sheet (only look at the rows entries that have Work category = "Testing")

My new testing sheet (this is where the majority of the work will happen)

Why

There's 3 WCAG 2.2 criteria that are a bit more technical and inspection heavy than the others:

Who needs to work on this

Accessibility specialist

Who needs to review this

Developers, Interaction designer

Tasks

### WCAG 2.2 issues to resolve
- [ ] https://github.com/alphagov/govuk-frontend/issues/4357
- [ ] https://github.com/alphagov/accessible-autocomplete/issues/604
- [ ] https://github.com/alphagov/govuk-design-system/issues/3256
- [ ] https://github.com/alphagov/govuk-frontend/issues/4469
- [ ] https://github.com/alphagov/govuk-frontend/issues/4470
- [ ] https://github.com/alphagov/govuk-frontend/issues/4471
- [ ] https://github.com/alphagov/govuk-frontend/issues/4472
dav-idc commented 10 months ago

The testing sheet is now complete! https://docs.google.com/spreadsheets/d/1PpKvhCGZJb1j0ZUUY2ZuA0CBQeu04yFD1bumiL8wGX8/edit?usp=sharing

Next step will be to glean potential Github issues that can be made from the 'focus appearance' entries (rows 31 to 61).

dav-idc commented 10 months ago

My final thoughts, for whomever picks this up:

owenatgov commented 10 months ago

@querkmachine made this comment investigating all our focus states and how well they meet (or don't meet) 2.4.13: focus appearance.

Looking at the testing spreadsheet, it appears that David was slightly more lenient in his interpretation. Most notably for inline links (see the row in the calculator for the check answers pattern for an equivalent visual element to test) David has taken into account the contrast change of the text itself which means it just passes. For everything else, David's testing lines up with @querkmachine's testing.

@querkmachine has recommended that our focus states overall need a more thorough review. The issues I've added to the "issues to resolve" task list are potential quick wins but we should think about how we present our focus states more thoroughly via https://github.com/alphagov/govuk-design-system/issues/3007 at some point.