Closed 36degrees closed 5 months ago
File | Size |
---|---|
dist/govuk-frontend-development.min.css | 113.37 KiB |
dist/govuk-frontend-development.min.js | 42.34 KiB |
packages/govuk-frontend/dist/govuk/all.bundle.js | 88.16 KiB |
packages/govuk-frontend/dist/govuk/all.bundle.mjs | 82.83 KiB |
packages/govuk-frontend/dist/govuk/all.mjs | 981 B |
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs | 359 B |
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css | 113.36 KiB |
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js | 42.33 KiB |
packages/govuk-frontend/dist/govuk/i18n.mjs | 5.55 KiB |
packages/govuk-frontend/dist/govuk/init.mjs | 4.86 KiB |
File | Size (bundled) | Size (minified) |
---|---|---|
all.mjs | 78.45 KiB | 40.31 KiB |
accordion.mjs | 22.71 KiB | 12.85 KiB |
button.mjs | 5.98 KiB | 2.69 KiB |
character-count.mjs | 22.4 KiB | 9.92 KiB |
checkboxes.mjs | 5.83 KiB | 2.83 KiB |
error-summary.mjs | 7.89 KiB | 3.46 KiB |
exit-this-page.mjs | 17.1 KiB | 9.26 KiB |
header.mjs | 4.46 KiB | 2.6 KiB |
notification-banner.mjs | 6.26 KiB | 2.62 KiB |
password-input.mjs | 15.15 KiB | 7.25 KiB |
radios.mjs | 4.83 KiB | 2.38 KiB |
skip-link.mjs | 4.39 KiB | 2.18 KiB |
tabs.mjs | 10.13 KiB | 6.11 KiB |
View stats and visualisations on the review app
Action run for 899012cf997c7317908ebfd678e246e0297a0b13
The diff could not be posted as a comment. You can download it from the workflow artifacts.
Action run for 899012cf997c7317908ebfd678e246e0297a0b13
The tests are failing because the snapshot names are different – the screenshots used to use the 'kebab case' example names hard coded in the task, and now they're using the examples names as they appear in the YAML which are typically space separated.
So Percy is showing this as 6 missing screenshots and 6 new screenshots.
Do we think it's important to maintain the existing screenshot names? It might cause some PRs to fail if they're not up to date with the changes introduced in this PR.
If not, we can simply approve the changes in Percy and move on.
Rather than hardcoding the list of additional examples to screenshot in the task, add a new
screenshot
boolean to the component YAML (and generated fixtures.yaml) which determines whether the example should be included in the screenshots or not.Preserve the existing list of screenshotted examples by setting
screenshot: true
in the YAML for those examples.Remove special treatment of examples named ‘inverse’ but retain their screenshots by also setting
screenshot: true
.