search

alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.17k stars 320 forks source link

Remove direct links to Polyfill[dot]io #5127

Closed domoscargin closed 2 months ago

domoscargin commented 2 months ago

Closes #5105

The included note bulked out the package code considerably (see #dcf4810), so I've gone with a single README in the polyfill folder.

If we wanted to include the note in the code itself, we could add a version of it to src/all.mjs. Then it'd only be included once. But that felt a bit misplaced.

To propagate the changes to the dist and package folders, we'd need to do a patch release. I considered just manually updating these and skipping the CHANGELOG entry, but this seems more transparent, despite being more hassle.

domoscargin commented 2 months ago

@owenatgov I've smooshed ALL related comments now, and added a CHANGELOG entry rather than manually edit the dist and package folders. Just makes everything more obvious, even if it means the hassle of a patch release at some point.

Note for future releasers: the diff to the dist folder was big enough that our validation checks fail because we can't generate a comment that large. We'll have to either disable that comment generation temporarily, or look into increasing its limit somehow?