search

alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.18k stars 323 forks source link

New typography scale causes wrapping of OGL text in footer #5290

Closed matteason closed 4 weeks ago

matteason commented 2 months ago

https://github.com/alphagov/govuk-frontend/pull/4064 (later feature-flagged: https://github.com/alphagov/govuk-frontend/commit/5fcf17619c736a258d526a2128cc77ec1f975dc2) increased the footer font size to 19px, which means the OGL licence text in the footer now wraps when viewed at full width at the default zoom level/text size:

Before (16px) GOV.UK footer with text on one line: All content is available under the Open Government Licence v3.0), except where otherwise stated

After (19px) GOV.UK footer with text on two lines, the last word on the second line: All content is available under the Open Government Licence v3.0

You can see this live on https://design-system.service.gov.uk/patterns/question-pages/default/

Typographically this looks a bit strange as it makes stated an orphan

github-actions[bot] commented 2 months ago

Uh oh! @matteason, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

romaricpascal commented 1 month ago

Hi @matteason, thanks for flagging that. I've proposed a fix in this draft PR, but it raises a few questions I'd like to put to the different specialists in the team so it may take a little before we fix the issue 😊