search

alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.18k stars 325 forks source link

Add component principle around keeping to the 5px spacing scale #867

Closed NickColley closed 5 years ago

NickColley commented 6 years ago

When adjusting the tag component I mistakenly broke a rule around heights for our components.

We should document this somewhere to help people in the future.

See Ollie's helpful comments: https://github.com/alphagov/govuk-frontend/pull/855#pullrequestreview-133602078 https://github.com/alphagov/govuk-frontend/pull/855#discussion_r199477367

dashouse commented 5 years ago

Closing this as it will be covered in #1121