alphagov / govuk-knowledge-graph-gcp

GOV.UK content data and cloud infrastructure for the GovSearch app.
https://docs.data-community.publishing.service.gov.uk/tools/govgraph/
MIT License
10 stars 1 forks source link

Don't use terraform for the project itself #344

Closed nacnudus closed 1 year ago

nacnudus commented 1 year ago

An accidental change to a project name or number could cause terraform to try to replace the project itself, which would mean it would delete the whole project, without warning.

nacnudus commented 1 year ago

Remove these resources from the config and the state.

# Create the project
resource "google_project" "project" {
  billing_account = var.billing_account # Uncomment once known
  folder_id       = var.folder_id
  name            = var.project_id
  project_id      = var.project_id
  labels = {
    # The value can only contain lowercase letters, numeric characters,
    # underscores and dashes. The value can be at most 63 characters long.
    # International characters are allowed.
    programme = "cpto",
    team      = "data-products",
  }
}
nacnudus commented 1 year ago

351 is a better alternative