search

alphagov / govuk-prototype-kit-private-beta

⚠️ This repository has been archived and the changes have been merged into https://github.com/alphagov/govuk-prototype-kit
MIT License
1 stars 2 forks source link

Update GOV.UK Frontend module #13

Closed joelanman closed 6 years ago

joelanman commented 6 years ago

Without a changelog its hard for me to know if I've covered all the changes from 0.0.18 to 0.0.19 - so I could really do with people checking if I've hit everything.

Updated:

dashouse commented 6 years ago

I noticed a number of spacing issues throughout caused by HTML defaults

All <p> tags will need the govuk-body class applied or be used inside the govuk-prose-scope

I ran through this branch and added my changes on top in this branch - https://github.com/alphagov/govuk-prototype-kit-private-beta/tree/frontend-update-type-spacing

I also added govuk-prose-scope wrapper to the docs and app level styles that aren't yet covered in GOV.UK Frontend

joelanman commented 6 years ago

@dashouse I merged your commits, and then removed references to the old markdown class, now we're using govuk-prose-scope (also docs which didnt seem to have a definition anywhere so wasn't doing anything).

I'm still not sure about adding <p class="govuk-body"> everywhere, and I gather we'll probably have to add classes to all links too in future. But we can address this in the future. For now this PR is probably doing everything it needs to, bringing the kit up to date with govuk-frontend 0.0.19 .