search

alphagov / govuk-prototype-kit-private-beta

⚠️ This repository has been archived and the changes have been merged into https://github.com/alphagov/govuk-prototype-kit
MIT License
1 stars 2 forks source link

Bump govuk frontend v22 #17

Closed NickColley closed 6 years ago

NickColley commented 6 years ago

Updates the prototype kit to the latest version of govuk-frontend

As part of https://trello.com/c/owSir2X5/615-update-pk-to-use-frontend-022

Note I include updates to anchors but govuk_template technically still styles focus states.

This covers both 21 and 22 releases of Frontend

joelanman commented 6 years ago

I think there's a link that needs the new class added:

https://github.com/alphagov/govuk-prototype-kit-private-beta/blob/master/app/config.js#L25

Just to note, like the p class="govuk-body", adding a class="govuk-link" feels like a step that makes the prototype kit more complicated, which is a shame. But lets go forward with it for now and tackle it later if it's an issue.

joelanman commented 6 years ago

~couple more :)~

~https://github.com/alphagov/govuk-prototype-kit-private-beta/blob/bump-govuk-frontend-v22/docs/views/about.html#L34-L35~

NickColley commented 6 years ago

@joelanman govuk-list styles anchors automatically, any others?

36degrees commented 6 years ago

Gah, you're right… that doesn't really make any sense. Lists aren't special…