search

alphagov / govuk-prototype-kit-private-beta

⚠️ This repository has been archived and the changes have been merged into https://github.com/alphagov/govuk-prototype-kit
MIT License
1 stars 2 forks source link

serviceName seems to have stopped working #57

Closed joelanman closed 6 years ago

joelanman commented 6 years ago

reproduce:

Set a serviceName in app/config.js

Expected the service name to change in the header, but it doesn't.

UPDATE

It's this line:

https://github.com/alphagov/govuk-prototype-kit-private-beta/blob/master/server.js#L211

I think we might need Object.assign to make a separate copy of app.locals, as it is one affects the other.

kr8n3r commented 6 years ago

me broke it :( Fixed in the PR