alphagov / govuk-prototype-kit-private-beta

⚠️ This repository has been archived and the changes have been merged into https://github.com/alphagov/govuk-prototype-kit
MIT License
1 stars 2 forks source link

DO NOT MERGE add backward compatibility #64

Closed joelanman closed 6 years ago

joelanman commented 6 years ago

This work allows people with large old prototypes to use the new prototype kit without having to rewrite everything.

On old pages, users would change this line:

{% extends "layout.html" %}

to this:

{% extends "layout-elements.html" %}

This layout is in lib/backward-compatibility along with all the necessary assets and views from version 6 of the kit. When a page is using layout-elements it now uses the old technology - Elements, Frontend toolkit, GOV.UK Template. It does not allow you to use Frontend.

The idea is people can upgrade page by page as needed, and any new pages would use the new technology in Frontend.

Issues:

1. If people have added their own css to app/assets/application.css how do they use that?

  1. I've used the words backward-compatibility, legacy, and elements at various points. We should probably just decide on one, maybe? Possibly two because elements is a well understood concept but not entirely technically accurate - this work provides more than just elements.
  2. Some JavaScript and images are missing