alphagov / govuk-prototype-kit-private-beta

⚠️ This repository has been archived and the changes have been merged into https://github.com/alphagov/govuk-prototype-kit
MIT License
1 stars 2 forks source link

Include govuk frontend module in Git #9

Closed joelanman closed 6 years ago

joelanman commented 6 years ago

This is a bit unusual, but because Frontend is currently password protected in NPM, including the modules here means:

The kit itself is private on GitHub, and will be behind a password when we make it available online.

This PR makes an exception in .gitignore for:

and adds them to the repo

kr8n3r commented 6 years ago

in principle i have no issues with thisas either way you have to share at least one of the passwords (npm test or this one or both)

joelanman commented 6 years ago

@igloosi cheers - sorry I just turned on requiring reviews before merge - do you mind approving?

kr8n3r commented 6 years ago

although it's going to cause pain when packages are updated

joelanman commented 6 years ago

that's true - not sure we have an alternative while we're in alpha/private beta