Closed hannalaakso closed 1 year ago
@joelanman Should the 'Steps to add' go inside 'Updating to Version 12'? Or should they go into a new section, titled something like 'Updating a prototype that's already on GitHub'?
@EoinShaughnessy ignore my last (now deleted comment), I had got myself confused.
I think you are right, this should go in 'Updating to Version 12', maybe with a small qualifier beforehand saying 'if you are using git/GitHub'
Thanks @lfdebrux! Would these steps go at the end of the current procedure, or somewhere inside it?
@EoinShaughnessy at the end, they should make sure they've completed the update and everything is still working before committing and pushing changes.
@lfdebrux Thanks! I'll raise a PR shortly.
I closed the PR I'd raised, as we don't know whether this issue has affected more than one user so far. Maybe one to revisit when we have more evidence it's causing problems.
Following review the Prototype Team are closing this ticket. If the original author wishes to raise this issue again please feel free.
Related documentation
https://govuk-prototype-kit.herokuapp.com/docs/updating-the-kit
Suggestion
We should consider adding some extra instructions to the update tutorial if the prototype was already on GitHub so that other people who have a local copy of the prototype get the changed files.
Steps to add (draft)
main
(or equivalent) branch and pull down the latest changes [...]Evidence (where applicable)
A user who was updating prototypes that were already on GitHub said that it wasn't clear that after the update was complete, they needed to commit and push up the changed files.