Closed joelanman closed 2 years ago
the PR for the last time we did this is here: https://github.com/alphagov/govuk-prototype-kit/pull/1127
@joelanman do we want version 12 to support Node 18?
@lfdebrux I think so? Otherwise we'd tell people to use 18 and it doesnt work. It's possible it just works as is, I dont think Engines technically has to change but I could be wrong
@joelanman okay. If we don't change the engines
directive in package.json
users will get a warning when they run npm install
:
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'govuk-prototype-kit@12.2.0',
npm WARN EBADENGINE required: { node: '>=12.0.0 <17.0.0' },
npm WARN EBADENGINE current: { node: 'v18.11.0', npm: '8.19.2' }
npm WARN EBADENGINE }
hmm not great, might be best to do a release - lets see what the rest of the team think
Looks like v12 can support Node 18 happily: https://github.com/alphagov/govuk-prototype-kit/pull/1700
I'd suggest:
@nataliecarey in case you missed it, the wider version support discussion with a recent update is here: https://github.com/alphagov/govuk-prototype-kit/issues/1124#issuecomment-1282395190
This was done for v12 in https://github.com/alphagov/govuk-prototype-kit/pull/1700, and v13 is already tested with Node 18, so I'm going to call this ticket done and close it.
What
Make any necessary updates to support Node 18 LTS (long term support), which launches 25 October
Why
We will change our guidance to install Node 18 LTS. When 18 becomes LTS, its the main link on Node homepage, its hard to get other versions.
Who needs to work on this
Who needs to review this
Done when