alphagov / govuk-prototype-kit

Rapidly create HTML prototypes of GOV.UK services
https://prototype-kit.service.gov.uk
MIT License
305 stars 236 forks source link

Make any necessary updates to support Node 18 LTS #1698

Closed joelanman closed 2 years ago

joelanman commented 2 years ago

What

Make any necessary updates to support Node 18 LTS (long term support), which launches 25 October

Why

We will change our guidance to install Node 18 LTS. When 18 becomes LTS, its the main link on Node homepage, its hard to get other versions.

Who needs to work on this

Who needs to review this

Done when

joelanman commented 2 years ago

the PR for the last time we did this is here: https://github.com/alphagov/govuk-prototype-kit/pull/1127

lfdebrux commented 2 years ago

@joelanman do we want version 12 to support Node 18?

joelanman commented 2 years ago

@lfdebrux I think so? Otherwise we'd tell people to use 18 and it doesnt work. It's possible it just works as is, I dont think Engines technically has to change but I could be wrong

lfdebrux commented 2 years ago

@joelanman okay. If we don't change the engines directive in package.json users will get a warning when they run npm install:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'govuk-prototype-kit@12.2.0',
npm WARN EBADENGINE   required: { node: '>=12.0.0 <17.0.0' },
npm WARN EBADENGINE   current: { node: 'v18.11.0', npm: '8.19.2' }
npm WARN EBADENGINE }
joelanman commented 2 years ago

hmm not great, might be best to do a release - lets see what the rest of the team think

lfdebrux commented 2 years ago

Looks like v12 can support Node 18 happily: https://github.com/alphagov/govuk-prototype-kit/pull/1700

nataliecarey commented 2 years ago

I'd suggest:

joelanman commented 2 years ago

@nataliecarey in case you missed it, the wider version support discussion with a recent update is here: https://github.com/alphagov/govuk-prototype-kit/issues/1124#issuecomment-1282395190

lfdebrux commented 2 years ago

This was done for v12 in https://github.com/alphagov/govuk-prototype-kit/pull/1700, and v13 is already tested with Node 18, so I'm going to call this ticket done and close it.