alphagov / govuk-prototype-kit

Rapidly create HTML prototypes of GOV.UK services
https://prototype-kit.service.gov.uk
MIT License
302 stars 236 forks source link

Build the enhanced plugin page #2305

Closed BenSurgisonGDS closed 1 year ago

BenSurgisonGDS commented 1 year ago

See https://github.com/alphagov/govuk-prototype-kit/issues/2298

Changes included:

Changes not included:

nataliecarey commented 1 year ago

I'm curious about the search rules...

Would users expect step by step govuk prototype kit to come up with:

Screenshot 2023-08-25 at 16 42 53

Would users expect templates common to come up with:

Screenshot 2023-08-25 at 16 44 04

Would users expect SMS to come up with:

Screenshot 2023-08-25 at 16 45 07

These cases would be catered for if we both include the metadata in the search logic and search for each word individually rather than the complete string.

(I don't think this is necessary for a first release but I think it's worth discussing)

As this hasn't yet been exactly defined, I went with what I thought was correct for now based on the name of each plugin, not any of the meta data. What do you think @joelanman and @oli-rose28?

nataliecarey commented 1 year ago

If I try to access these pages offline it claims that everything has upgrades available, I think it should do the opposite and not claim that any have upgrades available. Screenshot attached.

Screenshot 2023-08-25 at 17 27 05
nataliecarey commented 1 year ago

In the design the installed plugins also display in the "find plugins" section with a tag to say "installed". Was changing that an intentional decision?

BenSurgisonGDS commented 1 year ago

In the design the installed plugins also display in the "find plugins" section with a tag to say "installed". Was changing that an intentional decision?

I worked with @joelanman on this. The designs were not complete and so for an MVP, this is what we have and it can be extended later.