search

alphagov / govuk-prototype-kit

Rapidly create HTML prototypes of GOV.UK services
https://prototype-kit.service.gov.uk
MIT License
306 stars 236 forks source link

Nunjucks templates from GOV.UK Frontend plugin used internally #2352

Closed colinrotherham closed 1 year ago

colinrotherham commented 1 year ago

Description of the issue

Manage prototype pages use GOV.UK Frontend "internal" styles, scripts, images, fonts etc

But they're rendered using GOV.UK Frontend "plugin" Nunjucks views and macros

Steps to reproduce the issue

  1. Create a new prototype which uses govuk-frontend@4.7.0 by default
  2. Downgrade "plugin" GOV.UK Frontend using npm install govuk-frontend@4.2.0
  3. Start the prototype with USE_HTTPS=false PASSWORD=test to see the password page
  4. Click "Continue" to see the Error summary component
  5. Notice that fixed accessibility bugs have returned

Actual vs expected behaviour

Actual: Nunjucks templates from "plugin" GOV.UK Frontend are used Expected: Nunjucks templates from "internal" GOV.UK Frontend are used

colinrotherham commented 1 year ago

This was flagged whilst testing GOV.UK Frontend v5

Noticeably the class .js-enabled was missing its new .govuk-frontend-supported counterpart

colinrotherham commented 1 year ago

Currently in review: https://github.com/alphagov/govuk-prototype-kit/pull/2355