search

alphagov / govuk-prototype-kit

Rapidly create HTML prototypes of GOV.UK services
https://prototype-kit.service.gov.uk
MIT License
302 stars 236 forks source link

Don't use a table on the Check your answers example #306

Closed joelanman closed 7 years ago

joelanman commented 7 years ago

Using a table on Check your answers is bad from an accessibility point of view, because it isnt a table of data. We could use divs insteads

edwardhorsford commented 7 years ago

The accessibility team has this on our backlog of one of the patterns we'd like to fix.

In the short term I'm trying to stop linking to this code example from the service manual.

selfthinker commented 7 years ago

I started looking at various issues around this pattern. There will probably be a new version soon. See also the discussion on #334.

joelanman commented 7 years ago

@selfthinker any news on this? Thanks for looking into it!

selfthinker commented 7 years ago

I will pick this up again today. We'll hopefully have something to show (in form of a PR) by the end of the week.

selfthinker commented 7 years ago

Sorry for the long wait. Here is my PR: https://github.com/alphagov/govuk_prototype_kit/pull/365

gemmaleigh commented 7 years ago

Fixed by #365.