search

alphagov / govuk-prototype-kit

Rapidly create HTML prototypes of GOV.UK services
https://prototype-kit.service.gov.uk
MIT License
305 stars 236 forks source link

Update step by step navigation to use new focus states #755

Closed hannalaakso closed 5 years ago

hannalaakso commented 5 years ago

With the work done in https://github.com/alphagov/govuk-design-system/issues/677 and the upcoming release of GOV.UK Frontend that updates the focus states to be WCAG 2.1 compliant, we should update the Step by step navigation to use the new focus states.

hannalaakso commented 5 years ago

We need to get the GOV.UK Publishing to look at how the pattern should be updated.

NickColley commented 5 years ago

It's also worth noting that, user agent focus styles pass WCAG 2.1 requirements by technicality.

NickColley commented 5 years ago

This is now unblocked since GOV.UK Publishing have updated this pattern to use the new focus styles:

Screen Shot 2019-08-27 at 16 01 34 Screen Shot 2019-08-27 at 16 01 38

https://components.publishing.service.gov.uk/component-guide/step_by_step_nav/preview

We should take care not to re-introduce this bug: https://github.com/alphagov/govuk_publishing_components/issues/1058

NickColley commented 5 years ago

I spoke to @DebsDee and we think this would be good one to pair on.