search

alphagov / govuk-puppet

Decommissioned: Puppet manifests that used to provision the legacy GOV.UK stack.
MIT License
127 stars 41 forks source link

Delete old Vagrant credentials. #12158

Closed sengi closed 10 months ago

sengi commented 10 months ago

The Vagrant environment is long-dead (and only ever would have been run locally) but it's not a good look to have any kind of private key or password checked into a public repo (even if it's just for testing), so let's clean it up.

Addresses #12155, with credit to @annaobarz for bringing this to our attention.

sengi commented 10 months ago

Considered expunging it from the history, but I don't think it's worth it given the specifics of this case.

sengi commented 10 months ago

Ah of course it breaks the tests. Sigh.

sengi commented 10 months ago

Let's try that again.

sengi commented 10 months ago

Just to clarify, these keys etc. aren't used anywhere as far as I can tell, so there's nothing left to revoke etc. This is about removing a bunch of defunct (but still scary-looking) key material from HEAD so that a) it's clear that it's no longer in use and b) we have a record that we checked it's no longer in use.