search

alphagov / govuk_elements

❗️GOV.UK Elements is deprecated, and will only receive major bug fixes and security patches.
https://govuk-elements.herokuapp.com/
MIT License
227 stars 90 forks source link

Back link wrong colour when focused #540

Closed edwardhorsford closed 7 years ago

edwardhorsford commented 7 years ago

The back link changes to our standard govuk-blue when focused - I presume it should stay black.

Screenshot: screen shot 2017-08-07 at 11 13 37

kr8n3r commented 7 years ago

seem that all of our links when focused maintain their default gov.uk colour

a:link:focus {
    color: #005798;
}

and there is no exception for back link. if the consensus is to keep in black on focus that we can add it in.

NickColley commented 7 years ago

If you remove the border property's references to the black, it'll pick up the currentColor and end up looking like:

screen shot 2017-08-08 at 11 00 22

edwardhorsford commented 7 years ago

I suspect this regression was introduced by this pr: https://github.com/alphagov/govuk_template/pull/272

I think it should stay black. The reason we added the different blue focus colour was so that the contrast met our standards - this isn't a problem with the black links.

kr8n3r commented 7 years ago

got to love the generic a:link:focus ...

gemmaleigh commented 7 years ago

This was fixed by #544.