search

alphagov / govuk_elements

❗️GOV.UK Elements is deprecated, and will only receive major bug fixes and security patches.
https://govuk-elements.herokuapp.com/
MIT License
227 stars 90 forks source link

Adjust the icon position for legal text #547

Closed gemmaleigh closed 6 years ago

gemmaleigh commented 7 years ago

What problem does the pull request solve?

Ensure that the icon sits aligned with the middle of the first line of text, rather than vertically centred for the entire block of text.

Adjust the position for larger viewports, when the text size increases from 16px to 19px.

Screenshots

Before:

legal text - before - typography gov uk elements

After:

legal text - after - typography gov uk elements

For smaller viewports when the text wraps:

small screen - typography gov uk elements

For larger viewports with a single line of text:

wide screen - typography gov uk elements

trevorsaint commented 7 years ago

Brilliant Gemma ;)

edwardhorsford commented 7 years ago

Coming late to this party. Any reason it's not top-aligned to the top line of text?

I also wonder if it should scale with the font-size - but guess that would be a separate PR.

kr8n3r commented 7 years ago

@edwardhorsford yeah, the latter would be an svg solution