search

alphagov / govuk_elements

❗️GOV.UK Elements is deprecated, and will only receive major bug fixes and security patches.
https://govuk-elements.herokuapp.com/
MIT License
227 stars 90 forks source link

Should our colour naming be unopinionated #560

Closed charlesrt closed 7 years ago

charlesrt commented 7 years ago

Some of our colour names are opinionated.

This pull request changes them to be neutral, and also correctly spells fuchsia.

screen shot 2017-09-29 at 17 35 50

This change could be breaking if any of these Sass variables are being used.

36degrees commented 7 years ago

I don't know if this warrants a breaking release or if this is something we can address as part of the rollout of GOV.UK Frontend instead?

If we do want to change this in Elements there will need to be a corresponding PR for Frontend Toolkit to change the variable definitions themselves and we'll need to release a breaking version of that as well, unless we define both but mark the former as deprecated?

The tests are currently failing because of this – $fuchsia is not actually being defined.

NickColley commented 7 years ago

As this PR stands this would definitely be a breaking release, so would need to be backwards compat with deprecation warnings.

charlesrt commented 7 years ago

@fofr That's a good idea to make the colour naming simpler too.

@nickcolley You're right, this doesn't need to be a breaking change if the current Sass variables stay supported.

@36degrees I've confused myself as to how it all hangs together. The changes needs to happen in the frontend toolkit in _palette.scss which is pulled in. The only change to elements would be content.

I'll close this PR.

joelanman commented 7 years ago

Suggest 'plum' - easier to spell

charlesrt commented 7 years ago

@joelanman that's a good idea.

I raised this as an issue #561 to make debate possible (I probably should have done that first).