search

alphagov / govuk_elements

❗️GOV.UK Elements is deprecated, and will only receive major bug fixes and security patches.
https://govuk-elements.herokuapp.com/
MIT License
227 stars 90 forks source link

Possible accessibility issue with high contrast mode on Edge #569

Closed timpaul closed 6 years ago

timpaul commented 7 years ago

A team in NHS have reported some users struggling with our buttons in high contrast mode on Windows. They believe that they were using an Edge browser. Here's a screenshot:

image

As you can see the radios have big white borders, but the button background doesn't seem to have changed colour.

robinwhittleton commented 7 years ago

What would the expected behaviour be? White background and black text, or no border?

(radio buttons team, assemble!)

timpaul commented 7 years ago

For the radios I'd suggest no border. For the Next button - reverse video?

(Also, there's a chance they're using an old version of Elements...)

robinwhittleton commented 7 years ago

There was a problem with Win10 high contrast mode with old pre-release radios, but that screenshot is showing the fixed version. I don’t remember the outlines but I wouldn’t say for certain they weren’t there.

robinwhittleton commented 7 years ago

Just tested on Elements and am not seeing the problem with radio buttons in the photo. Is there a link to the site they were testing on nhs.uk?

selfthinker commented 7 years ago

I cannot reproduce that (neither for the buttons nor the radio buttons) in Windows High Contrast mode in Edge on Windows 10. But are we sure they used the Windows setting for that? Could they have used a tool instead or browser settings? Or could they have used an additional setting which could have caused that? I only tested the default settings, so it could well be there is a problem with some less standard settings.

selfthinker commented 7 years ago

By the way, you can see in the screenshot that it is Edge. (But it would be impossible to find out what tool they used, except that it changed the colours of the whole desktop, not just the browser, so at least cannot be browser settings.)

36degrees commented 6 years ago

Following the launch of the GOV.UK Design System, GOV.UK Elements will now only get major bug fixes and security patches, so given that we've not been able to reproduce this I'm going to close this.