alphagov / govuk_elements

❗️GOV.UK Elements is deprecated, and will only receive major bug fixes and security patches.
https://govuk-elements.herokuapp.com/
MIT License
227 stars 90 forks source link

Wrap snippets in div.form-group for consistency #604

Closed edwardhorsford closed 6 years ago

edwardhorsford commented 6 years ago

What problem does the pull request solve?

Half the snippets on the form examples page include div.form-group and half don't. This inconsistency causes us issues when teaching the Prototype kit. In nearly all cases our users will actually want to have the div.form-group for correct spacing.

NB - this means some of the visual examples now have extra whitespace at the bottom. We could remove this, but since this shows the effect of the spacing div, I think it's probably better to leave in.

I've not updated any examples outside of the form examples page.

How has this been tested?

Have run it locally.

Screenshots (if appropriate):

Before: screen shot 2018-04-18 at 10 43 47 After: screen shot 2018-04-18 at 10 43 24

What type of change is it?

Only impacts the elements style guide.

Has the documentation been updated?

Don't think any documentation is relevant