search

alphagov / govuk_elements

❗️GOV.UK Elements is deprecated, and will only receive major bug fixes and security patches.
https://govuk-elements.herokuapp.com/
MIT License
227 stars 90 forks source link

Fix missing arrow on `<details>` element In Firefox #611

Closed kr8n3r closed 6 years ago

kr8n3r commented 6 years ago

Removes the Firefox hack and replace it with the custom css triangle solution developed in GOV.UK Frontend. Also deletes the _shame.scss file as it's no longer needed.

What problem does the pull request solve?

Fixes a missing open/close indicator on details element in Firefox.

How has this been tested?

Screenshots (if appropriate):

Firefox:

screen shot 2018-07-04 at 15 37 21 screen shot 2018-07-04 at 15 37 40

Other browsers: Preview url: https://govuk-elements-review-pr-611.herokuapp.com/typography/#typography-hidden-text

What type of change is it?

Has the documentation been updated?

36degrees commented 6 years ago

Seeing duplicated arrows in IE8 through IE11. I believe this is because these browsers do not natively support the <details> element, and we add the marker using JavaScript. We don't have this problem in GOV.UK Frontend because we've removed that responsibility from the JS.

screen shot 2018-07-04 at 15 51 58bst
36degrees commented 6 years ago

Annoyingly, that happens over in https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/details.polyfill.js#L174-L186

kr8n3r commented 6 years ago

yeah, just 'fixed' that there were styles in the Sass partials for that arrow already