search

alphagov / govuk_frontend_toolkit

❗️GOV.UK Frontend Toolkit is deprecated, and will only receive major bug fixes and security patches.
MIT License
403 stars 107 forks source link

For discussion: Make alpha, beta and discovery colours $govuk-blue #370

Closed gemmaleigh closed 7 years ago

gemmaleigh commented 7 years ago

The phase tag is now $govuk-blue (as previously the pink and orange colours used failed contrast requirements).

Do we want to update the Sass variables for $alpha-colour, $beta-colour and $discovery-colour to also use $govuk-blue?

Opened as this related issue was raised with the service manual: https://github.com/gds-attic/government-service-design-manual/issues/671

accessiblewebuk commented 7 years ago

Is this also about changing page http://govuk-elements.herokuapp.com/colour - if so then we should remove the status colours from that page, apart from $error-message (even though that red is in the main palette, it helps people know that it should be used for error messages and status bars.

gemmaleigh commented 7 years ago

It's partly about changing the Colour page for elements.

That page can be updated without affecting the frontend toolkit, so I've made those changes: https://github.com/alphagov/govuk_elements/pull/385

I'm also concerned about there being references to old colours that aren't being used any more. It would be good if there was a way to deprecate these, if we can agree that they should only be used for printed materials.

gemmaleigh commented 7 years ago

@tvararu I was thinking of something like this! https://github.com/salesforce-ux/sass-deprecate