search

alphagov / govuk_frontend_toolkit

❗️GOV.UK Frontend Toolkit is deprecated, and will only receive major bug fixes and security patches.
MIT License
403 stars 107 forks source link

Proposal: add a 'positive' colour. #386

Closed edwardhorsford closed 6 years ago

edwardhorsford commented 7 years ago

There are cases where it's useful to have a colour with a semantic meaning of 'positive'.

We already have error_colour which is a good red for 'negative' - but we don't have a counterpart.

We could use an existing colour, or make a new colour. Either way, a semantic SASS name would be good.

The closest colour would be button_colour. An alternate would be #008800 which is the green used by petitions. It's warmer, which feels more positive to me.

screen shot 2017-02-27 at 16 55 19

Thoughts?

NickColley commented 7 years ago

@edwardhorsford since this is in response to 'done' pages' use of turquoise, should we show how this colour would be used and also see if we should deprecate the turquoise?

edwardhorsford commented 7 years ago

@nickcolley it's related, but isn't in response to that - it's something I've thought about a few times before.

kr8n3r commented 6 years ago

@edwardhorsford shall we raise this in Frontend and close here?

edwardhorsford commented 6 years ago

@igloosi yes that's probably a good idea.

kr8n3r commented 6 years ago

closing in favour of issue in govuk-frontend