search

alphagov / govuk_frontend_toolkit

❗️GOV.UK Frontend Toolkit is deprecated, and will only receive major bug fixes and security patches.
MIT License
403 stars 107 forks source link

Fixes for Travis when deploying #393

Closed gemmaleigh closed 7 years ago

gemmaleigh commented 7 years ago

This PR moves the open_ssl command back to before_install, otherwise it runs more than once (as there is more than one deploy provider).

Related Travis issue here: https://github.com/travis-ci/travis-ci/issues/2570

This behaviour was reverted in GOV.UK elements here: https://github.com/alphagov/govuk_elements/pull/415

Before deploying, also check that the build has passed successfully.

dsingleton commented 7 years ago

👍 LGTM.

The before_deploy behaviour being per-deploy is somewhat unexpected :(

We're going to be looking at https://github.com/alphagov/govuk_template/pull/267 with @alexmuller on Monday, lets see if we can find a nicer way for the future then.