search

alphagov / govuk_frontend_toolkit

❗️GOV.UK Frontend Toolkit is deprecated, and will only receive major bug fixes and security patches.
MIT License
403 stars 107 forks source link

ARIA attributes set by GOVUK.ShowHideContent are invalid #419

Closed gemmaleigh closed 6 years ago

gemmaleigh commented 7 years ago

Raised on GOV.UK elements.

LJWatson commented 7 years ago

Removing the aria-expanded attribute will solve one problem and introduce another. Without the attribute, there is no way for screen reader users to know that the show/hide functionality is there.

As noted in alphagov/govuk_elements#455, I don't think using radio buttons as a show/hide trigger is a good design pattern (at least not for screen reader users). The level of support across browsers for aria-expanded on a radio button or checkbox is also unknown.

36degrees commented 6 years ago

Following the launch of the GOV.UK Design System, GOV.UK Frontend Toolkit will now only get major bug fixes and security patches, so I'm going to close this as it's not actionable.

There's a lot of valuable discussion on the related issue over in Elements – we'll try to capture that as best as we can before we close that.