search

alphagov / govuk_frontend_toolkit

❗️GOV.UK Frontend Toolkit is deprecated, and will only receive major bug fixes and security patches.
MIT License
403 stars 107 forks source link

Remove multivariate test javascript #420

Closed fofr closed 7 years ago

fofr commented 7 years ago

GOV.UK now has an alternative AB testing strategy which is server side. A server side approach prevents flashes of content. Deleting this logic will reduce the risk of creating tests that might be inaccessible, such as this: https://github.com/alphagov/frontend/pull/1228#pullrequestreview-37664574

Even when no tests are running, GOV.UK includes this JS on every page: https://github.com/alphagov/static/blob/master/app/assets/javascripts/application.js#L4

After discussion with @nickcolley, on the belief that this has mainly been used by GOV.UK, we think this library could be removed. It would be a breaking change with a major version bump. Apps that still require the tests could copy the javascript across.

cc @carvil @alecgibson

NickColley commented 7 years ago

cc @chao-xian @ikennaokpala

carvil commented 7 years ago

This sounds good to me @fofr ! When merged please update the manual page on A/B tests here: https://docs.publishing.service.gov.uk/manual/ab-testing.html

ikennaokpala commented 7 years ago

Let me check with Polly on the content team about when this AB test should end cc\ @fofr @nickcolley

fofr commented 7 years ago

AB test documentation updated here: https://github.com/alphagov/govuk-developer-docs/pull/292