alphagov / govuk_frontend_toolkit

❗️GOV.UK Frontend Toolkit is deprecated, and will only receive major bug fixes and security patches.
MIT License
403 stars 107 forks source link

Fixes media player volume button overlap #429

Closed vanitabarrett closed 7 years ago

vanitabarrett commented 7 years ago

Fixes #853. Volume up and down buttons in the media player were overlapping the current volume percentage on focus. This fix keeps the large button touch area, but adjust the focus state to be smaller.

Before: volume button focus state overlaps the current volume percentage:

screen shot 2017-07-18 at 14 36 38

After: volume button touch area remains the same as previously, but focus state is smaller so as not to obscure current volume percentage: This shows the new focus state:

screen shot 2017-07-18 at 14 14 51

But we can see that the touch area remains the same:

screen shot 2017-07-18 at 14 14 35

This means the volume controls continue to work on small devices where all icons are more closely located together:

screen shot 2017-07-18 at 14 15 34