search

alphagov / govuk_frontend_toolkit

❗️GOV.UK Frontend Toolkit is deprecated, and will only receive major bug fixes and security patches.
MIT License
403 stars 107 forks source link

Breadcrumb link accessibility #460

Closed jamie-lovell closed 6 years ago

jamie-lovell commented 6 years ago

Hi, The breadcrumb tag currently doesn't change colour in its hover state. In an app that we're building using breadcrumbs, it's failing accessibility because of this. Considering the link is styled black with an underline - what would the guidance be for the colour to change to on hover? Happy to make the change in a PR.

36degrees commented 6 years ago

Hi Jamie,

Thanks for raising this.

I am not aware of any requirement that says links must have a distinct hover state, as long as it's clear that they are clickable. It would be good to understand what you mean when you say it's failing accessibility – is this something that's been flagged in an audit or by automated testing tools?

Thanks,

Ollie

36degrees commented 6 years ago

Following the launch of the GOV.UK Design System, GOV.UK Frontend Toolkit will now only get major bug fixes and security patches, so I'm going to close this.

The behaviour of the breadcrumbs is the same in GOV.UK Design System / Frontend as it is in Elements, so if you believe this is still an issue please add it to the backlog issue for Breadcrumbs.