Google Analytics date regex is very specific - Githubissues

alphagov / govuk_frontend_toolkit

❗️GOV.UK Frontend Toolkit is deprecated, and will only receive major bug fixes and security patches.

MIT License

403 stars 107 forks source link

Google Analytics date regex is very specific #469

Closed lewisnyman closed 6 years ago

lewisnyman commented 6 years ago

Hi, I was just testing out the date regex that strips PII from Google Analytics events. It seems like the regex only captures dates in the format: XXXX-XX-XX

My initial test was XX/XX/XXXX, which wasn't being caught. It might be worth making the regex a bit more flexible?

NickColley commented 6 years ago

Related conversation about flexibility: https://github.com/alphagov/govuk_frontend_toolkit/pull/466#issuecomment-405517391

36degrees commented 6 years ago

Following the launch of the GOV.UK Design System, GOV.UK Frontend Toolkit will now only get major bug fixes and security patches, so I'm going to close this.

GOV.UK Design System (and GOV.UK Frontend) does not provide any analytics functionality, and as far as I know there are currently no plans to provide this either as part of Frontend nor as a separate library.