search

alphagov / govuk_publishing_components

A gem to document and distribute frontend components for GOV.UK applications
https://components.publishing.service.gov.uk
MIT License
66 stars 20 forks source link

Modernizr isn't needed #2240

Closed andysellick closed 1 month ago

andysellick commented 3 years ago

We have modernizr in the components gem but it only appears to be used on the admin layout, targeting browsers less than IE9.

We should investigate whether we really need it and whether it can be removed.

It was introduced in this PR: https://github.com/alphagov/govuk_publishing_components/pull/422

andysellick commented 2 years ago

Admin layout isn't used on the public site - only in publishing applications (think just content-publisher and content-data) where users may be stuck using older browsers, so we should probably still support them.

jon-kirwan commented 1 month ago

I’m wondering if we might actually be able to remove Modernizr now.

The gem version of Modernizr has the following configuration:

I can’t find any 'no feature' styles configured for no-flexbox or no-flexboxtweener anywhere in the publishing applications (or for anywhere that uses the admin template). I searched for no-flexbox and no-flexboxtweener. Same for the History API Finally, there's the printshiv option (allowing HTML5 elements to be styled and contain children while being printed in IE 6-8). Is it safe to assume that printing admin pages in browsers older than IE9 isn't a major requirement?

The admin template is used by: