search

alphagov / govuk_publishing_components

A gem to document and distribute frontend components for GOV.UK applications
https://components.publishing.service.gov.uk
MIT License
66 stars 20 forks source link

Navigation items misaligned on Layout super nav component #2331

Closed fofr closed 3 years ago

fofr commented 3 years ago

https://components.publishing.service.gov.uk/component-guide/layout_super_navigation_header

The "Departments" text is 1px misaligned with the two drop downs either side of it:

Screenshot 2021-09-30 at 17 00 39

There’s also a 1px misalignment on the search box toggle when open and focused vs closed and focused (note the black bar on the X image): Screenshot 2021-09-30 at 17 08 09 Screenshot 2021-09-30 at 17 08 06

injms commented 3 years ago

Firstly, thanks for reporting these visual issues.

The misalignment of "Departments" should hopefully be fixed in the coming week or so.

The black line on the button is deliberately placed to differentiate between the cookie banner and open section:

image

This small border isn't an ideal solution - it's going to be iterated on to find something that doesn't look so glitchy when the cookie banner isn't present but doesn't make the cookie banner and an open section look connected.

injms commented 3 years ago

I'm closing this as the alignment was fixed in https://github.com/alphagov/govuk_publishing_components/pull/2401 - which has now been released in the gem and then bumped in the application that renders the header.