alphagov / govuk_publishing_components

A gem to document and distribute frontend components for GOV.UK applications
https://components.publishing.service.gov.uk
MIT License
66 stars 20 forks source link

Design issues: Intervention component -- Dismiss link #3237

Open nnagewad opened 1 year ago

nnagewad commented 1 year ago

Component in question

Intervention component with dismiss link

Issue

Screenshot

Screenshot 2023-02-06 at 16 18 02

Proposed solution

nnagewad commented 1 year ago

This may be an opportunity to rethink this. Should it be styled like a link? Or should it be more aligned to the call-to-actions within the Accordion?

Screenshots

Base state

Screenshot 2023-02-06 at 16 30 08

Hover state

Screenshot 2023-02-06 at 16 30 36

Focus state

Screenshot 2023-02-06 at 16 30 45

monicacrusellasfanlo commented 1 year ago

This actually made me think about the way we deal with wrapped links in the related content section too: https://www.gov.uk/guidance/appoint-someone-to-deal-with-customs-on-your-behalf

https://user-images.githubusercontent.com/106598959/217033793-0e909e5c-1170-49da-8132-d7fc835bc348.mov

I think the hide this suggestion and Show 10 more should not be links. When styled like links it gives the impression that it will open a new page. I'd probably use the accordion styling instead.

JamesCGDS commented 1 year ago

Hi @nnagewad @monicacrusellasfanlo, sorry for the delay in getting round to this. Just wanted to check in and ask if a decision was reached on whether we want to just tweak this to remove the extra underline or rethink the component?

nnagewad commented 5 months ago

@JamesCGDS lets start by removing the extra underline