alphagov / learningtime-ad-sem1-postcode-geocoder

Early talent assigned learning time, Antoni's Semester 1 project for creating a postcode geolocation app.
2 stars 0 forks source link

Separated cli and postcode logic #30

Closed antoni-devlin closed 1 year ago

antoni-devlin commented 1 year ago

Moved functions around so the postcode validating, converting, and formatting logic lives in postcodes.js.

Cli.js now contains only functions required to interact with postcode.js using the command line.

antoni-devlin commented 1 year ago
  • The title on this commit is good, but could we expand on the "why" here in a deeper message. You might want to lave yourself even more detail on what benefits that kind of separation brings? If you put this down for a year and had to pick it up later and remind yourself, what could you say in this commit to help you remember why you did this?

@huwd Updated the commit here to be more descriptive by:

Looks like it's worked as expected, so I'll merge this :D