alphagov / manuals-publisher

Publishes manuals on GOV.UK
https://docs.publishing.service.gov.uk/apps/manuals-publisher.html
MIT License
7 stars 16 forks source link

Add Smokey feature for Manuals Publisher #866

Closed floehopper closed 7 years ago

floehopper commented 7 years ago

At first glance, it doesn't look as if there are any features specific to manuals: https://github.com/alphagov/smokey/tree/master/features.

Todo

floehopper commented 7 years ago

The only smoke tests for a publishing app are these ones for the mainstream publisher, but at least there is a precedent.

danielroseman commented 7 years ago

Sorry to barge in on your thread, but the publishing platform team are doing some work on running end-to-end tests from apps to frontends in CI using Docker, see https://github.com/alphagov/publishing-e2e-tests - might be useful for manuals-publisher too.

floehopper commented 7 years ago

@danielroseman: Thanks! That does sound very relevant.

chrisroos commented 7 years ago

We think that having some Smokey tests would have alerted us to the problem we started seeing after upgrading to Mongoid 3 in PR #929. We were seeing 504 Gateway timeout errors when viewing the /manuals index page.

chrisroos commented 7 years ago

Ruben in 2ndline has granted the manuals-publisher permission to the test signon user.

chrisroos commented 7 years ago

I've opened PR alphagov/smokey#258 to add a test for manuals-publisher.

chrisroos commented 7 years ago

I've opened PR alphagov/govuk-puppet#5825 to enable email notifications for Smokey build failures.

chrisroos commented 7 years ago

I've received email notifications for Smokey build failures so I'm happy that this is all done. Closing.