alphagov / notifications-api

GOV.UK Notify API
https://www.notifications.service.gov.uk/documentation
MIT License
65 stars 25 forks source link

add script that tests downgrade scripts for new migrations #4224

Closed leohemsted closed 1 month ago

leohemsted commented 1 month ago

if this script finds new migration files, it will

as this just runs the whole branch's diff, this doesn't cover cases where an individual downgrade script is bad, but all when combined with the other downgrade scripts in that branch it works out ok (imagine if you have two versions in a PR, but the downgrade for both alembic versions only happens in the function for one of them).

But i think this is okay as a first step

next steps: