search

alphagov / notifications-api

GOV.UK Notify API
https://www.notifications.service.gov.uk/documentation
MIT License
65 stars 25 forks source link

in task, expect values deserialised from json #4244

Closed leohemsted closed 1 week ago

leohemsted commented 2 weeks ago

being a bit more explicit with type hints should hopefully remind us that the values in the task are just json dumped, so aren't rich enums or date objects

note: i've tested this manually locally by using curl and sending an example payload they provided us, but with my own db's UUID swapped. seems to work end-to-end (as well as my local setup works, which is barely at all)

klssmith commented 2 weeks ago

With your second commit message of using the callback queue in order to be the same as email/sms, isn't it only when sending the callbacks to services that we use the callbacks queue? We use "ses-callbacks" and "sms-callbacks" when processing receipts.

leohemsted commented 2 weeks ago

oops, you're right, good spot. i'll need a new queue and to update the terraform for the worker to read from it 😩

leohemsted commented 2 weeks ago

@klssmith squashed out in https://github.com/alphagov/notifications-api/pull/4244/commits/4d009198651cd828e0bdd32f1dc5d72d03eeb640