alphagov / notifications-java-client

Java client for the GOV.UK Notify API
https://central.sonatype.com/artifact/uk.gov.service.notify/notifications-java-client
MIT License
8 stars 30 forks source link

Remove commons lang3 #213

Closed willp-bl closed 1 year ago

willp-bl commented 1 year ago

The new behaviour here should be essentially the same as before, including for null values. The trim() will remove whitespace at the beginning and end of the string so there will need to be >=1 non-whitespace character for trim().length() to be non zero, and therefore for isBlank() to return false..

What problem does the pull request solve?

Removes a dependency

Checklist

samuelhwilliams commented 1 year ago

Thanks @willp-bl - this looks good to me 👍 Would you mind doing a patch bump on the Java client version and including a line in the changelog? Then I think we can merge this 🙌