alphagov / notifications-java-client

Java client for the GOV.UK Notify API
https://central.sonatype.com/artifact/uk.gov.service.notify/notifications-java-client
MIT License
8 stars 30 forks source link

Add unsubscribe_link to the client when sending emails #238

Closed willp-bl closed 5 months ago

willp-bl commented 5 months ago

https://trello.com/c/Sp4nata5/21-update-java-client-library-to-send-unsubscribe-link

Changes based on those in https://github.com/alphagov/notifications-python-client/pull/241

quis commented 5 months ago

Will need changing from unsubscribe_link and unsubscribeLink to one_click_unsubscribe_url and oneClickUnsubscribeURL to match https://github.com/alphagov/notifications-api/pull/4084

quis commented 5 months ago

All looks fairly sensible to me but would benefit from a review from someone on the Notify team with a bit of Java experience. I notice you have oneClickUnsubscribeLink in lots of places. For the field in the JSON and in other clients we’ve gone with oneClickUnsubscribeURL.

Other things you could add to smooth this through: