Where UUIDs are expected change the type from String

alphagov / notifications-java-client

Java client for the GOV.UK Notify API

https://central.sonatype.com/artifact/uk.gov.service.notify/notifications-java-client

MIT License

8 stars 30 forks source link

Where UUIDs are expected change the type from String #241

Open willp-bl opened 5 months ago

willp-bl commented 5 months ago

What problem does the pull request solve?

Changes the external API to ensure that UUID are passed instead of a String

Checklist

[x] I’ve used the pull request template
[ ] I’ve written unit tests for these changes
[ ] I’ve updated the documentation in
- [ ] notifications-tech-docs repository
- [x] CHANGELOG.md
[ ] I’ve bumped the version number
- [ ] in src/main/resources/application.properties
- [ ] in pom.xml

quis commented 1 month ago

Is the improvement this gives worth making a breaking change to service’s code? Do we think consumers are handling UUIDs as UUIDs in their code, or just strings?