chore: add new fields to notification class (cost_in_pounds, is_data_ready and cost_details) - Githubissues

alphagov / notifications-java-client

Java client for the GOV.UK Notify API

https://central.sonatype.com/artifact/uk.gov.service.notify/notifications-java-client

MIT License

8 stars 30 forks source link

chore: add new fields to notification class (cost_in_pounds, is_data_ready and cost_details) #244

Closed joybytes closed 3 months ago

joybytes commented 3 months ago

What problem does the pull request solve?

New fields have been added to the response of get_notification(notificationId) endpoint

cost_in_pounds
is_cost_data_ready
cost_details: -- Nested fields for letters: --- billable_sheets_of_paper --- postage -- Nested fields for sms: --- billable_sms_fragments --- international_rate_multiplier --- sms_rate

Based on the addition this PR updates our client documentation to showcase an aligned response for the endpoint

Related task :

3. Add GET notification cost data to API clients and API client docs

Checklist

[x] I’ve used the pull request template
[x] I’ve written unit tests for these changes
[x] I’ve updated the documentation in
- [x] notifications-tech-docs repository
- [x] CHANGELOG.md
[x] I’ve bumped the version number
- [x] in src/main/resources/application.properties
- [x] in pom.xml