Upgrade dockerfile used for tests

alphagov / notifications-net-client

.NET client for the GOV.UK Notify API

https://www.nuget.org/packages/GovukNotify/

MIT License

25 stars 20 forks source link

Upgrade dockerfile used for tests #138

Closed idavidmcdonald closed 3 years ago

idavidmcdonald commented 3 years ago

We were using 2.1 of .NET core but this is not end of life.

You can see on https://hub.docker.com/_/microsoft-dotnet-sdk that 3.1 is long term support.

Also note, that the repo name has changed as per https://github.com/dotnet/dotnet-docker/issues/2375.

Also note, I could have upgraded us to 5.1 but I went for 3.1 for two reasons

it's a smaller change
good to know that we support the oldest .net stuff so we don't add anything in that is only supported by newer versions

However, I could be easily persuaded to choose 5.1 instead.

What problem does the pull request solve?

Checklist

[x] I’ve used the pull request template
[ ] I’ve written unit tests for these changes
[ ] I’ve update the documentation (in DOCUMENATION.md and CHANGELOG.md)
[ ] I’ve bumped the version number (in src/Notify/Notify.csproj)

idavidmcdonald commented 3 years ago

Completely agree on the matrix. We have a bit of matrix testing for the python app, this is done using tox but I think I'd prefer all of the different combinations to be different concourse jobs (so we'd have several concourse tasks/jobs for each client that each check a different range). I'm not so keen on tox as it's another new tool to learn, I don't want us to have an equivalent for each client language so docker/concourse jobs would be the straight forward way of doing it in a consistent way

My other slight worry, not that it should necessarily be a reason about not doing it, is that we sometimes struggle to keep all the clients up to date and running OK so just want to make sure if we commit to testing on different language versions, that we can actually keep up with the maintenance work of fixes.

benthorner commented 3 years ago

I think I'd prefer all of the different combinations to be different concourse jobs

That does sound better...

we can actually keep up with the maintenance work of fixes

...but would need that overall investment. I guess at some point we could decide to focus on the clients and make process improvements like these. I know there's a least one feature request in the backlog 😄.

idavidmcdonald commented 3 years ago

Ha, now you can go implement the feature request you suggested. Who would have guessed when you were writing that issue that you might be the one to fix it!

benthorner commented 3 years ago

🙈