Added support for cancellation tokens - Githubissues

alphagov / notifications-net-client

.NET client for the GOV.UK Notify API

https://www.nuget.org/packages/GovukNotify/

MIT License

25 stars 20 forks source link

Added support for cancellation tokens #178

Open euantorano opened 12 months ago

euantorano commented 12 months ago

What problem does the pull request solve?

Fixes #176 by adding support for passing CancellationToken parameters to asynchronous methods.

Also fixes #130 - rather than accessing a Task result directly the task should be awaited.

These changes allow early cancellation of requests.

Checklist

[x] I’ve used the pull request template
[x] I’ve written unit tests for these changes
[x] I’ve update the documentation (in DOCUMENATION.md and CHANGELOG.md)
[x] I’ve bumped the version number (in src/GovukNotify/GovukNotify.csproj)

euantorano commented 11 months ago

I'm not sure why but it looks like the CI may be stalled on this one. Would someone mind giving it a nudge?

The changes mentioned in the previous comment will be explored in a future PR after this one has been merged.